]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: sja1105: fix port mirroring for P/Q/R/S
authorVladimir Oltean <vladimir.oltean@nxp.com>
Sat, 30 May 2020 10:29:53 +0000 (13:29 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sun, 31 May 2020 01:00:36 +0000 (18:00 -0700)
commitd0b29eca7652fd166e8ad9960c78e6de106517dd
tree8e91f8d9274419d6ea69588cc2b7848fb6a023dc
parentcaad0b979f2e4c5e7e6e0c180a9e61819b04e0bc
net: dsa: sja1105: fix port mirroring for P/Q/R/S

The dynamic configuration interface for the General Params and the L2
Lookup Params tables was copy-pasted between E/T devices and P/Q/R/S
devices. Nonetheless, these interfaces are bitwise different.

The driver is using dynamic reconfiguration of the General Parameters
table for the port mirroring feature, which was therefore broken on
P/Q/R/S.

Note that this patch can't be backported easily very far to stable trees
(since it conflicts with some other development done since the
introduction of the driver). So the Fixes: tag is purely informational.

Fixes: 6772132ada66 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/sja1105/sja1105_dynamic_config.c
drivers/net/dsa/sja1105/sja1105_static_config.c
drivers/net/dsa/sja1105/sja1105_static_config.h