]> git.baikalelectronics.ru Git - kernel.git/commit
net: x25: Increase refcnt of "struct x25_neigh" in x25_rx_call_request
authorXie He <xie.he.0141@gmail.com>
Thu, 12 Nov 2020 10:35:06 +0000 (02:35 -0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 13 Nov 2020 02:01:40 +0000 (18:01 -0800)
commitd097a847cc7bcac967855cbae917411b1d458e15
tree4cbaefadd16d1c1c2a475ddab9d51611dd74c94a
parente75b2a88c0fc83275f5711268b08c97aaa771c3b
net: x25: Increase refcnt of "struct x25_neigh" in x25_rx_call_request

The x25_disconnect function in x25_subr.c would decrease the refcount of
"x25->neighbour" (struct x25_neigh) and reset this pointer to NULL.

However, the x25_rx_call_request function in af_x25.c, which is called
when we receive a connection request, does not increase the refcount when
it assigns the pointer.

Fix this issue by increasing the refcount of "struct x25_neigh" in
x25_rx_call_request.

This patch fixes frequent kernel crashes when using AF_X25 sockets.

Fixes: ffcf38937155 ("net/x25: Fix x25_neigh refcnt leak when x25 disconnect")
Cc: Martin Schiller <ms@dev.tdt.de>
Signed-off-by: Xie He <xie.he.0141@gmail.com>
Link: https://lore.kernel.org/r/20201112103506.5875-1-xie.he.0141@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/x25/af_x25.c