]> git.baikalelectronics.ru Git - kernel.git/commit
mISDN: fix possible use-after-free in HFC_cleanup()
authorZou Wei <zou_wei@huawei.com>
Tue, 11 May 2021 06:58:53 +0000 (14:58 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 11 May 2021 23:12:46 +0000 (16:12 -0700)
commitd0423db70f9d282e3d290a55b2b4cef64f9d0f4c
treedad9c927d7228136d5f041304f6edb78ebaf5448
parent9212b2e2c14e1a0e962a20263f1bee712325917a
mISDN: fix possible use-after-free in HFC_cleanup()

This module's remove path calls del_timer(). However, that function
does not wait until the timer handler finishes. This means that the
timer handler may still be running after the driver's remove function
has finished, which would result in a use-after-free.

Fix by calling del_timer_sync(), which makes sure the timer handler
has finished, and unable to re-schedule itself.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hardware/mISDN/hfcpci.c