]> git.baikalelectronics.ru Git - kernel.git/commit
regmap: Make regmap_noinc_read() return -ENOTSUPP if map->read isn't set
authorJavier Martinez Canillas <javierm@redhat.com>
Thu, 16 Jun 2022 07:34:34 +0000 (09:34 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 20 Jun 2022 15:51:28 +0000 (16:51 +0100)
commitcffd22235c9100fad0adcca3ad37bd3f809f40d7
treebd145122d2aa6109a41df8e4ff4c2c6cf21e86f2
parentace2dc003b9940c5f744f6217adbaf0e74d84a0a
regmap: Make regmap_noinc_read() return -ENOTSUPP if map->read isn't set

Before adding support to define bulk read/write callbacks in regmap_config
by the commit 71ba7e7abdcd ("regmap: Add bulk read/write callbacks into
regmap_config"), the regmap_noinc_read() function returned an errno early
a map->bus->read callback wasn't set.

But that commit dropped the check and now a call to _regmap_raw_read() is
attempted even when bulk read operations are not supported. That function
checks for map->read anyways but there's no point to continue if the read
can't succeed.

Also is a fragile assumption to make so is better to make it fail earlier.

Fixes: 71ba7e7abdcd ("regmap: Add bulk read/write callbacks into regmap_config")
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Link: https://lore.kernel.org/r/20220616073435.1988219-3-javierm@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/base/regmap/regmap.c