]> git.baikalelectronics.ru Git - kernel.git/commit
net: encx24j600: Fix invalid logic in reading of MISTAT register
authorValentina Goncharenko <goncharenko.vp@ispras.ru>
Thu, 1 Dec 2022 17:34:08 +0000 (20:34 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Dec 2022 10:30:45 +0000 (11:30 +0100)
commitcfc4fe9c6f94db4dc68c96a4d4eb07f53686c603
treea9fca0964e8730e638a91b48e734c8fcd98c9437
parentde3f591522e7378bf07c2a88f5fb0b29d509cc29
net: encx24j600: Fix invalid logic in reading of MISTAT register

[ Upstream commit 25f427ac7b8d89b0259f86c0c6407b329df742b2 ]

A loop for reading MISTAT register continues while regmap_read() fails
and (mistat & BUSY), but if regmap_read() fails a value of mistat is
undefined.

The patch proposes to check for BUSY flag only when regmap_read()
succeed. Compile test only.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 2b27d5f85455 ("net: Microchip encx24j600 driver")
Signed-off-by: Valentina Goncharenko <goncharenko.vp@ispras.ru>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/microchip/encx24j600-regmap.c