]> git.baikalelectronics.ru Git - kernel.git/commit
rhashtable: fix for resize events during table walk
authorPhil Sutter <phil@nwl.cc>
Mon, 6 Jul 2015 13:51:20 +0000 (15:51 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 8 Jul 2015 21:53:49 +0000 (14:53 -0700)
commitcfc0544380a869e4124d3e65a438960b9746d689
tree7012b4dc717e3d745ac6da012a593ca49849a2a7
parent48e7bb3d8bcd2e7c3228b834d51dfaeb36cf1ad8
rhashtable: fix for resize events during table walk

If rhashtable_walk_next detects a resize operation in progress, it jumps
to the new table and continues walking that one. But it misses to drop
the reference to it's current item, leading it to continue traversing
the new table's bucket in which the current item is sorted into, and
after reaching that bucket's end continues traversing the new table's
second bucket instead of the first one, thereby potentially missing
items.

This fixes the rhashtable runtime test for me. Bug probably introduced
by Herbert Xu's patch 84c65765 ("rhashtable: Fix walker behaviour during
rehash") although not explicitly tested.

Fixes: 84c65765 ("rhashtable: Fix walker behaviour during rehash")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
lib/rhashtable.c