]> git.baikalelectronics.ru Git - kernel.git/commit
tpm: fix error return code in tpm2_get_cc_attrs_tbl()
authorZhen Lei <thunder.leizhen@huawei.com>
Wed, 12 May 2021 13:39:26 +0000 (21:39 +0800)
committerJarkko Sakkinen <jarkko@kernel.org>
Wed, 12 May 2021 19:36:50 +0000 (22:36 +0300)
commitcf493403020aff3cf2b4218eab41d71d99565e5c
treef954ac74c9bdd849135e3852f106ffd60588d684
parent041cac6990be137cca1d302b8601fbc4ba325172
tpm: fix error return code in tpm2_get_cc_attrs_tbl()

If the total number of commands queried through TPM2_CAP_COMMANDS is
different from that queried through TPM2_CC_GET_CAPABILITY, it indicates
an unknown error. In this case, an appropriate error code -EFAULT should
be returned. However, we currently do not explicitly assign this error
code to 'rc'. As a result, 0 was incorrectly returned.

Cc: stable@vger.kernel.org
Fixes: 53089ff611e7("tpm: validate TPM 2.0 commands")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
drivers/char/tpm/tpm2-cmd.c