]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: megaraid_sas: Fix data integrity failure for JBOD (passthrough) devices
authorKashyap Desai <kashyap.desai@broadcom.com>
Fri, 21 Oct 2016 13:33:32 +0000 (06:33 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 25 Oct 2016 01:31:43 +0000 (21:31 -0400)
commitce7c0405af91ec84fac1f51fd1bae842528478d8
tree5c2b23a174bd21b90c81e34f7ebfe265e8468077
parent6768a89d2c12cc462fb72f739549c5d2d5fd504a
scsi: megaraid_sas: Fix data integrity failure for JBOD (passthrough) devices

Commit 5c8fb9ee4e89 ("megaraid_sas: return sync cache call with
success") modified the driver to successfully complete SYNCHRONIZE_CACHE
commands without passing them to the controller. Disk drive caches are
only explicitly managed by controller firmware when operating in RAID
mode. So this commit effectively disabled writeback cache flushing for
any drives used in JBOD mode, leading to data integrity failures.

[mkp: clarified patch description]

Fixes: 5c8fb9ee4e891eb3b83f2e32f81b864f050d24be
CC: stable@vger.kernel.org
Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/megaraid/megaraid_sas_base.c