]> git.baikalelectronics.ru Git - kernel.git/commit
splice: only read in as much information as there is pipe buffer space
authorDarrick J. Wong <darrick.wong@oracle.com>
Tue, 15 Oct 2019 15:44:32 +0000 (08:44 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Tue, 15 Oct 2019 15:44:32 +0000 (08:44 -0700)
commitccf12c9b868db54d65b8135db726494e51a9a3ba
tree0589c615a6c8228a2a8b049dc6e4ab1643bb09ad
parent1a1521bb50a95f9e476c2109d83bfa47e4706c56
splice: only read in as much information as there is pipe buffer space

Andreas Grünbacher reports that on the two filesystems that support
iomap directio, it's possible for splice() to return -EAGAIN (instead of
a short splice) if the pipe being written to has less space available in
its pipe buffers than the length supplied by the calling process.

Months ago we fixed splice_direct_to_actor to clamp the length of the
read request to the size of the splice pipe.  Do the same to do_splice.

Fixes: f08bd32bdc326 ("splice: don't read more than available pipe space")
Reported-by: syzbot+3c01db6025f26530cf8d@syzkaller.appspotmail.com
Reported-by: Andreas Grünbacher <andreas.gruenbacher@gmail.com>
Reviewed-by: Andreas Grünbacher <andreas.gruenbacher@gmail.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/splice.c