]> git.baikalelectronics.ru Git - kernel.git/commit
tg3: Fix for tg3 transmit queue 0 timed out when too many gso_segs
authorSiva Reddy Kallam <siva.kallam@broadcom.com>
Wed, 3 Feb 2016 08:39:38 +0000 (14:09 +0530)
committerDavid S. Miller <davem@davemloft.net>
Tue, 9 Feb 2016 09:39:14 +0000 (04:39 -0500)
commitccad3f0d700116fe8f669648047e9228594fae0b
tree95aae805073fc667290d60c6877414ad73946052
parent55a065f92e7aaa91627fe21a3059ffc48d97df16
tg3: Fix for tg3 transmit queue 0 timed out when too many gso_segs

tg3_tso_bug() can hit a condition where the entire tx ring is not big
enough to segment the GSO packet. For example, if MSS is very small,
gso_segs can exceed the tx ring size. When we hit the condition, it
will cause tx timeout.

tg3_tso_bug() is called to handle TSO and DMA hardware bugs.
For TSO bugs, if tg3_tso_bug() cannot succeed, we have to drop the packet.
For DMA bugs, we can still fall back to linearize the SKB and let the
hardware transmit the TSO packet.

This patch adds a function tg3_tso_bug_gso_check() to check if there
are enough tx descriptors for GSO before calling tg3_tso_bug().
The caller will then handle the error appropriately - drop or
lineraize the SKB.

v2: Corrected patch description to avoid confusion.

Signed-off-by: Siva Reddy Kallam <siva.kallam@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Acked-by: Prashant Sreedharan <prashant@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/tg3.c