]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "net: stmicro: fix a missing check of clk_prepare"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:56:47 +0000 (13:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 15:30:47 +0000 (17:30 +0200)
commitcb9cd82c7913b1b0a0a29d89e7bc1e5691642317
tree9341fec98b02089e422c7a0f6c453244365dd03b
parent8e1fbbfe213d415293c1461050adfd8ac63d242b
Revert "net: stmicro: fix a missing check of clk_prepare"

This reverts commit 2b1cc58b5eff549dac48dff18bde6c13295faa83.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

The original commit causes a memory leak when it is trying to claim it
is properly handling errors.  Revert this change and fix it up properly
in a follow-on commit.

Cc: Kangjie Lu <kjlu@umn.edu>
Cc: David S. Miller <davem@davemloft.net>
Fixes: 2b1cc58b5eff ("net: stmicro: fix a missing check of clk_prepare")
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210503115736.2104747-21-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c