]> git.baikalelectronics.ru Git - kernel.git/commit
arm64: Improve diagnostics when trapping BRK with FAULT_BRK_IMM
authorWill Deacon <will@kernel.org>
Tue, 15 Sep 2020 14:48:09 +0000 (15:48 +0100)
committerWill Deacon <will@kernel.org>
Fri, 18 Sep 2020 15:35:54 +0000 (16:35 +0100)
commitcaacb641a6aba6f47f55a0d3bc44b9da1fd1393a
tree4e0af87c4923a4edbb310bf1ff1e0985f1c3b169
parentbeea5f8bd9170d3d0e6476d33bde88d795ce40b0
arm64: Improve diagnostics when trapping BRK with FAULT_BRK_IMM

When generating instructions at runtime, for example due to kernel text
patching or the BPF JIT, we can emit a trapping BRK instruction if we
are asked to encode an invalid instruction such as an out-of-range]
branch. This is indicative of a bug in the caller, and will result in a
crash on executing the generated code. Unfortunately, the message from
the crash is really unhelpful, and mumbles something about ptrace:

  | Unexpected kernel BRK exception at EL1
  | Internal error: ptrace BRK handler: f2000100 [#1] SMP

We can do better than this. Install a break handler for FAULT_BRK_IMM,
which is the immediate used to encode the "I've been asked to generate
an invalid instruction" error, and triage the faulting PC to determine
whether or not the failure occurred in the BPF JIT.

Link: https://lore.kernel.org/r/20200915141707.GB26439@willie-the-truck
Reported-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/include/asm/extable.h
arch/arm64/kernel/debug-monitors.c
arch/arm64/kernel/traps.c
arch/arm64/mm/extable.c