]> git.baikalelectronics.ru Git - kernel.git/commit
MIPS: math-emu: Remove pr_err() calls from fpu_emu()
authorPaul Burton <paul.burton@imgtec.com>
Fri, 8 Sep 2017 22:12:21 +0000 (15:12 -0700)
committerRalf Baechle <ralf@linux-mips.org>
Mon, 9 Oct 2017 14:33:34 +0000 (16:33 +0200)
commitca8eb05b5f332a9e1ab3e2ece498d49f4d683470
tree07323bde05e5d316b9e91b81491a4014bf37c432
parente1270575fb7ee7ed6058d4ad3714a3b28001a295
MIPS: math-emu: Remove pr_err() calls from fpu_emu()

The FPU emulator includes 2 calls to pr_err() which are triggered by
invalid instruction encodings for MIPSr6 cmp.cond.fmt instructions.
These cases are not kernel errors, merely invalid instructions which are
already handled by delivering a SIGILL which will provide notification
that something failed in cases where that makes sense.

In cases where that SIGILL is somewhat expected & being handled, for
example when crashme happens to generate one of the affected bad
encodings, the message is printed with no useful context about what
triggered it & spams the kernel log for no good reason.

Remove the pr_err() calls to make crashme run silently & treat the bad
encodings the same way we do others, with a SIGILL & no further kernel
log output.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Fixes: f8c3c6717a71 ("MIPS: math-emu: Add support for the CMP.condn.fmt R6 instruction")
Cc: linux-mips@linux-mips.org
Cc: stable <stable@vger.kernel.org> # v4.3+
Patchwork: https://patchwork.linux-mips.org/patch/17253/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/math-emu/cp1emu.c