]> git.baikalelectronics.ru Git - kernel.git/commit
vdpa_sim: set last_used_idx as last_avail_idx in vdpasim_queue_ready
authorEugenio Pérez <eperezma@redhat.com>
Thu, 2 Mar 2023 18:18:57 +0000 (19:18 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Mar 2023 12:33:44 +0000 (13:33 +0100)
commitc99612cc6cc6ea36e27f08e1b453279a7585b5a5
treebd02d8ae07ad67a0cb2ee56fc3936e63a5f08efe
parentb68a4ec99f8cbb07b599973f37360c61246d6e71
vdpa_sim: set last_used_idx as last_avail_idx in vdpasim_queue_ready

[ Upstream commit dd7bf530a232f84431ab744bebcc4295c1f20645 ]

Starting from an used_idx different than 0 is needed in use cases like
virtual machine migration.  Not doing so and letting the caller set an
avail idx different than 0 causes destination device to try to use old
buffers that source driver already recover and are not available
anymore.

Since vdpa_sim does not support receive inflight descriptors as a
destination of a migration, let's set both avail_idx and used_idx the
same at vq start.  This is how vhost-user works in a
VHOST_SET_VRING_BASE call.

Although the simple fix is to set last_used_idx at vdpasim_set_vq_state,
it would be reset at vdpasim_queue_ready.  The last_avail_idx case is
fixed with commit 6a52d6f4cc11 ("vdpa_sim: not reset state in
vdpasim_queue_ready").  Since the only option is to make it equal to
last_avail_idx, adding the only change needed here.

This was discovered and tested live migrating the vdpa_sim_net device.

Fixes: a903b8ae96c5 ("vdpasim: vDPA device simulator")
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Message-Id: <20230302181857.925374-1-eperezma@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/vdpa/vdpa_sim/vdpa_sim.c