]> git.baikalelectronics.ru Git - kernel.git/commit
clk: renesas: cpg-mssr: Fix use after free if cpg_mssr_common_init() failed
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Fri, 23 Dec 2022 14:40:17 +0000 (17:40 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 15:43:50 +0000 (16:43 +0100)
commitc9425a0c89f73f71e76aee06d3a85c30a4bf0cc7
tree5a06e7a29cbf8342493248319162494daf9f81ab
parente3faf74ffcee1cb7b5bac6ffa71c7aabd1631f5d
clk: renesas: cpg-mssr: Fix use after free if cpg_mssr_common_init() failed

[ Upstream commit fbfd614aeaa2853c2c575299dfe2458db8eff67e ]

If cpg_mssr_common_init() fails after assigning priv to global variable
cpg_mssr_priv, it deallocates priv, but cpg_mssr_priv keeps dangling
pointer that potentially can be used later.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 21ee18a8becf ("clk: renesas: cpg-mssr: Add early clock support")
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/1671806417-32623-1-git-send-email-khoroshilov@ispras.ru
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/renesas/renesas-cpg-mssr.c