]> git.baikalelectronics.ru Git - kernel.git/commit
net: cxgb3_main: Add CAP_NET_ADMIN check to CHELSIO_GET_MEM
authorMichael Ellerman <mpe@ellerman.id.au>
Fri, 24 Jan 2020 09:41:44 +0000 (20:41 +1100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 25 Jan 2020 09:50:42 +0000 (10:50 +0100)
commitc91f8b8e105ee2a2e01938f0cdcc89366972487c
treec1c0066f6821e617a1429f7f77ea924a8304a768
parent0c9f025d45075516dbe5977c3feaf20bd98b747c
net: cxgb3_main: Add CAP_NET_ADMIN check to CHELSIO_GET_MEM

The cxgb3 driver for "Chelsio T3-based gigabit and 10Gb Ethernet
adapters" implements a custom ioctl as SIOCCHIOCTL/SIOCDEVPRIVATE in
cxgb_extension_ioctl().

One of the subcommands of the ioctl is CHELSIO_GET_MEM, which appears
to read memory directly out of the adapter and return it to userspace.
It's not entirely clear what the contents of the adapter memory
contains, but the assumption is that it shouldn't be accessible to all
users.

So add a CAP_NET_ADMIN check to the CHELSIO_GET_MEM case. Put it after
the is_offload() check, which matches two of the other subcommands in
the same function which also check for is_offload() and CAP_NET_ADMIN.

Found by Ilja by code inspection, not tested as I don't have the
required hardware.

Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c