]> git.baikalelectronics.ru Git - kernel.git/commit
PCI: Fix incorrect argument order to list_add_tail() in PCI dynamic ID code
authorMichael Ellerman <michael@ellerman.id.au>
Fri, 14 Sep 2007 05:33:13 +0000 (15:33 +1000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 12 Oct 2007 22:03:17 +0000 (15:03 -0700)
commitc88f60983e6527227a6b7210ed949e5399047774
tree052d752634d36fc4997c7224cd9a546497c19490
parentb2e5dc1de4d0486c96c363c2459982ec1a56f4d7
PCI: Fix incorrect argument order to list_add_tail() in PCI dynamic ID code

The code for dynamically assigning new ids to PCI drivers,
store_new_id(), calls list_add_tail() with the list head and new node
arguments in reversed order.

The result is that every new id written essentially overwrites the
previous list of ids.

Caught with the help of Rusty's "horribly bad" list_node patch:
 http://lkml.org/lkml/2007/6/10/10

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/pci/pci-driver.c