]> git.baikalelectronics.ru Git - kernel.git/commit
ice: Fix error with handling of bonding MTU
authorDave Ertman <david.m.ertman@intel.com>
Fri, 18 Feb 2022 20:39:25 +0000 (12:39 -0800)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 8 Mar 2022 21:31:08 +0000 (13:31 -0800)
commitc88840ae6aadea1e09e4f436a980ff0df35a5c7a
tree14d61a08fe0801b1e7241162e615d2dbfa1d728e
parent04dfbb7f0d5d0858e98e0c627db2a45e12cd563f
ice: Fix error with handling of bonding MTU

When a bonded interface is destroyed, .ndo_change_mtu can be called
during the tear-down process while the RTNL lock is held.  This is a
problem since the auxiliary driver linked to the LAN driver needs to be
notified of the MTU change, and this requires grabbing a device_lock on
the auxiliary_device's dev.  Currently this is being attempted in the
same execution context as the call to .ndo_change_mtu which is causing a
dead-lock.

Move the notification of the changed MTU to a separate execution context
(watchdog service task) and eliminate the "before" notification.

Fixes: f316c8300c2f7 ("ice: Implement iidc operations")
Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
Tested-by: Jonathan Toppins <jtoppins@redhat.com>
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice.h
drivers/net/ethernet/intel/ice/ice_main.c