]> git.baikalelectronics.ru Git - kernel.git/commit
ieee1394: mark char device files as not seekable
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Sat, 10 Apr 2010 15:47:18 +0000 (16:47 +0100)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Sat, 10 Apr 2010 14:51:15 +0000 (16:51 +0200)
commitc86feeb330b8d77a81a100cc7a9a85cf95236ba9
tree6600d3171afdfad430155f5e8a1f526367a6174d
parentdb6bd51699c2c7cc94de8f758cd996a9b29da9d1
ieee1394: mark char device files as not seekable

The
  - raw1394   (/dev/raw1394),
  - video1394 (/dev/video1394/*),
  - dv1394    (/dev/dv1394/*)
character device file ABIs do not make any use of lseek(), pread(), or
pwrite().  Therefore use nonseekable_open() and, redundantly, set
file_operations.llseek to no_llseek to remove any doubt whether the BKL-
grabbing default_llseek handler is used.

Although all this is legacy code which should be left in peace until it
is eventually removed (as it is superseded by firewire-core's
<linux/firewire-cdev.h> ABI), this change seems still worth doing to
further minimize the presence of BKL usage in the kernel.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/ieee1394/dv1394.c
drivers/ieee1394/raw1394.c
drivers/ieee1394/video1394.c