]> git.baikalelectronics.ru Git - kernel.git/commit
gfs2: don't lock sd_ail_lock in gfs2_releasepage
authorBob Peterson <rpeterso@redhat.com>
Tue, 18 Aug 2020 16:50:28 +0000 (11:50 -0500)
committerAndreas Gruenbacher <agruenba@redhat.com>
Thu, 15 Oct 2020 12:29:03 +0000 (14:29 +0200)
commitc838950c0e9dd127a635283e58b29c612fb78150
tree4b408ff9ede74ef72917c88946a3f9b3318d26b0
parentea9ce6e29bce3ef209790f6dc437811babfb341f
gfs2: don't lock sd_ail_lock in gfs2_releasepage

Patch c5468b1b35055fbb21641d2e9014304d17502520 changed gfs2_releasepage
so that it held the sd_ail_lock spin_lock for most of its processing.
It did this for some mysterious undocumented bug somewhere in the
evict code path. But in the nine years since, evict has been reworked
and fixed many times, and so have the transactions and ail list.
I can't see a reason to hold the sd_ail_lock unless it's protecting
the actual ail lists hung off the transactions. Therefore, this patch
removes the locking to increase speed and efficiency, and to further help
us rework the log flush code to be more concurrent with transactions.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
fs/gfs2/aops.c