]> git.baikalelectronics.ru Git - kernel.git/commit
video: fbdev: arkfb: Check the size of screen before memset_io()
authorZheyu Ma <zheyuma97@gmail.com>
Thu, 4 Aug 2022 12:41:24 +0000 (20:41 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:24:16 +0000 (14:24 +0200)
commitc831a334220cd25dbf0b388c33f81d6689d74626
tree0964c4b9a59074f355d2431c9b09a01044615339
parent52ad52e7d88cdd4d98b18d3d96d77abaa60b724e
video: fbdev: arkfb: Check the size of screen before memset_io()

[ Upstream commit e04d54793e947de1cb45c7aba412f68bed9a6f89 ]

In the function arkfb_set_par(), the value of 'screen_size' is
calculated by the user input. If the user provides the improper value,
the value of 'screen_size' may larger than 'info->screen_size', which
may cause the following bug:

[  659.399066] BUG: unable to handle page fault for address: ffffc90003000000
[  659.399077] #PF: supervisor write access in kernel mode
[  659.399079] #PF: error_code(0x0002) - not-present page
[  659.399094] RIP: 0010:memset_orig+0x33/0xb0
[  659.399116] Call Trace:
[  659.399122]  arkfb_set_par+0x143f/0x24c0
[  659.399130]  fb_set_var+0x604/0xeb0
[  659.399161]  do_fb_ioctl+0x234/0x670
[  659.399189]  fb_ioctl+0xdd/0x130

Fix the this by checking the value of 'screen_size' before memset_io().

Fixes: dbd58d3aadcf ("arkfb: new framebuffer driver for ARK Logic cards")
Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/video/fbdev/arkfb.c