]> git.baikalelectronics.ru Git - kernel.git/commit
can: isotp: remove re-binding of bound socket
authorOliver Hartkopp <socketcan@hartkopp.net>
Fri, 22 Apr 2022 08:23:37 +0000 (10:23 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 29 Apr 2022 09:02:47 +0000 (11:02 +0200)
commitc8254a7af771a07613979c40a6167f8287c5dc37
treed497c068bed11bef7d6c2a8f9263a00b6259ff0c
parent01f53072760b7069aa3fe73798d3deb8aeec25da
can: isotp: remove re-binding of bound socket

As a carry over from the CAN_RAW socket (which allows to change the CAN
interface while mantaining the filter setup) the re-binding of the
CAN_ISOTP socket needs to take care about CAN ID address information and
subscriptions. It turned out that this feature is so limited (e.g. the
sockopts remain fix) that it finally has never been needed/used.

In opposite to the stateless CAN_RAW socket the switching of the CAN ID
subscriptions might additionally lead to an interrupted ongoing PDU
reception. So better remove this unneeded complexity.

Fixes: 3f9425168a78 ("can: add ISO 15765-2:2016 transport protocol")
Link: https://lore.kernel.org/all/20220422082337.1676-1-socketcan@hartkopp.net
Cc: stable@vger.kernel.org
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
net/can/isotp.c