]> git.baikalelectronics.ru Git - kernel.git/commit
usb: renesas: silence uninitialized variable report in usbhsg_recip_run_handle()
authorJesper Juhl <jj@chaosbits.net>
Mon, 16 Jan 2012 21:42:10 +0000 (22:42 +0100)
committerFelipe Balbi <balbi@ti.com>
Tue, 24 Jan 2012 13:43:06 +0000 (15:43 +0200)
commitc80f38c61cc2ee9f9e8fcc9f47660432a1c87eba
tree37c424c5e8795a810f2eeefe35a7a35aa48a8b2d
parent207c7705d33a1416b99ac6fde8252d4c7858124f
usb: renesas: silence uninitialized variable report in usbhsg_recip_run_handle()

In drivers/usb/renesas_usbhs/mod_gadget.c::usbhsg_recip_run_handle()
the Coverity Prevent checker currently flags a warning about possibly
uninitialized use of 'ret' i usbhsg_recip_run_handle(). It does this
since it assumes we take one of the non-default branches in the switch
and then subsequently take the false branch in the 'if (func)' case
below. This exact scenario will never happen, but Coverity can't see
that for some reason. This patch initializes 'ret' to '0' when it is
declared which should shut up this report and won't really hurt - so
why not? At least then it's clear that 'ret' is always initialized..

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/renesas_usbhs/mod_gadget.c