]> git.baikalelectronics.ru Git - kernel.git/commit
r8169: Clear RTL_FLAG_TASK_*_PENDING when clearing RTL_FLAG_TASK_ENABLED
authorKai-Heng Feng <kai.heng.feng@canonical.com>
Mon, 10 Sep 2018 17:51:43 +0000 (01:51 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 12 Sep 2018 07:05:33 +0000 (00:05 -0700)
commitc7b6e33206822564ecf95b6e9ef6847b7e775ac5
treea7a6ec1248a66f265fd71ee64358c3ac171e4e09
parent2e669fb41b57a2b2445e764097a4ee671181549d
r8169: Clear RTL_FLAG_TASK_*_PENDING when clearing RTL_FLAG_TASK_ENABLED

After system suspend, sometimes the r8169 doesn't work when ethernet
cable gets pluggued.

This issue happens because rtl_reset_work() doesn't get called from
rtl8169_runtime_resume(), after system suspend.

In rtl_task(), RTL_FLAG_TASK_* only gets cleared if this condition is
met:
if (!netif_running(dev) ||
    !test_bit(RTL_FLAG_TASK_ENABLED, tp->wk.flags))
    ...

If RTL_FLAG_TASK_ENABLED was cleared during system suspend while
RTL_FLAG_TASK_RESET_PENDING was set, the next rtl_schedule_task() won't
schedule task as the flag is still there.

So in addition to clearing RTL_FLAG_TASK_ENABLED, also clears other
flags.

Cc: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169.c