]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: fix reference counting for LAG FDBs
authorVladimir Oltean <vladimir.oltean@nxp.com>
Sat, 23 Jul 2022 01:24:11 +0000 (04:24 +0300)
committerJakub Kicinski <kuba@kernel.org>
Tue, 26 Jul 2022 02:37:06 +0000 (19:37 -0700)
commitc7560d1203b7a1ea0b99a5c575547e95d564b2a8
tree9ae41522750add3ed40077f03e70f59393c95d94
parent5fcbb711024aac6d4db385623e6f2fdf019f7782
net: dsa: fix reference counting for LAG FDBs

Due to an invalid conflict resolution on my side while working on 2
different series (LAG FDBs and FDB isolation), dsa_switch_do_lag_fdb_add()
does not store the database associated with a dsa_mac_addr structure.

So after adding an FDB entry associated with a LAG, dsa_mac_addr_find()
fails to find it while deleting it, because &a->db is zeroized memory
for all stored FDB entries of lag->fdbs, and dsa_switch_do_lag_fdb_del()
returns -ENOENT rather than deleting the entry.

Fixes: c26933639b54 ("net: dsa: request drivers to perform FDB isolation")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20220723012411.1125066-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/dsa/switch.c