]> git.baikalelectronics.ru Git - kernel.git/commit
ppp: Fix throttling bugs
authorAlan Cox <alan@linux.intel.com>
Mon, 22 Jun 2009 17:42:29 +0000 (18:42 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 22 Jun 2009 18:32:24 +0000 (11:32 -0700)
commitc73e2fe808432374619cccc12ee0e4841412bfa2
tree07482a4a9da12f754231598371d0bf5e1f691c66
parent4915ac3ef0da89c23eaad8d0c2640c01334f22e2
ppp: Fix throttling bugs

The ppp layer goes around calling the unthrottle method from non sleeping
paths. This isn't safe because the unthrottle methods in the tty layer need
to be able to sleep (consider a USB dongle).

Until now this didn't show up because the ppp layer never actually throttled
a port so the unthrottle was always a no-op. Currently it's a mutex taking
path so warnings are spewed if the unthrottle occurs via certain paths.

Fix this by removing the unneccessary unthrottle calls.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/net/ppp_async.c
drivers/net/ppp_synctty.c