]> git.baikalelectronics.ru Git - kernel.git/commit
autofs - remove obsolete d_invalidate() from expire
authorIan Kent <raven@themaw.net>
Wed, 10 Sep 2014 01:56:22 +0000 (09:56 +0800)
committerAl Viro <viro@zeniv.linux.org.uk>
Thu, 9 Oct 2014 06:38:52 +0000 (02:38 -0400)
commitc688615b85a82c19728d4da10d96cedbcf9b72f2
tree965aa5da27bc5db7799fb6eae216683ced4a286f
parented1ac74112a410bbd8f28b829b39a03a69c09d64
autofs - remove obsolete d_invalidate() from expire

Biederman's umount-on-rmdir series changes d_invalidate() to sumarily remove
mounts under the passed in dentry regardless of whether they are busy
or not. So calling this in fs/autofs4/expire.c:autofs4_tree_busy() is
definitely the wrong thing to do becuase it will silently umount entries
instead of just cleaning stale dentrys.

But this call shouldn't be needed and testing shows that automounting
continues to function without it.

As Al Viro correctly surmises the original intent of the call was to
perform what shrink_dcache_parent() does.

If at some time in the future I see stale dentries accumulating
following failed mounts I'll revisit the issue and possibly add a
shrink_dcache_parent() call if needed.

Signed-off-by: Ian Kent <raven@themaw.net>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/autofs4/expire.c