]> git.baikalelectronics.ru Git - kernel.git/commit
iomap: get/put the page in iomap_page_create/release()
authorPiotr Jaroszynski <pjaroszynski@nvidia.com>
Sun, 27 Jan 2019 16:46:45 +0000 (08:46 -0800)
committerDarrick J. Wong <darrick.wong@oracle.com>
Sun, 27 Jan 2019 16:46:45 +0000 (08:46 -0800)
commitc6337c5009dc14e6e3f6172ddc085f3bb3978dab
tree773bfb2fa1c56fb1682181a9e8dbd54fef0b25c5
parent8b5c1a1b081cff38bca27a6abe1da0f1accff3a0
iomap: get/put the page in iomap_page_create/release()

migrate_page_move_mapping() expects pages with private data set to have
a page_count elevated by 1.  This is what used to happen for xfs through
the buffer_heads code before the switch to iomap in commit 1a354192bcc1
("xfs: add support for sub-pagesize writeback without buffer_heads").
Not having the count elevated causes move_pages() to fail on memory
mapped files coming from xfs.

Make iomap compatible with the migrate_page_move_mapping() assumption by
elevating the page count as part of iomap_page_create() and lowering it
in iomap_page_release().

It causes the move_pages() syscall to misbehave on memory mapped files
from xfs.  It does not not move any pages, which I suppose is "just" a
perf issue, but it also ends up returning a positive number which is out
of spec for the syscall.  Talking to Michal Hocko, it sounds like
returning positive numbers might be a necessary update to move_pages()
anyway though.

Fixes: 1a354192bcc1 ("xfs: add support for sub-pagesize writeback without buffer_heads")
Signed-off-by: Piotr Jaroszynski <pjaroszynski@nvidia.com>
[hch: actually get/put the page iomap_migrate_page() to make it work
      properly]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/iomap.c