]> git.baikalelectronics.ru Git - kernel.git/commit
drm/tegra: Remove gratuitous pad field
authorThierry Reding <treding@nvidia.com>
Wed, 9 Apr 2014 12:26:59 +0000 (14:26 +0200)
committerThierry Reding <treding@nvidia.com>
Wed, 16 Apr 2014 15:11:04 +0000 (17:11 +0200)
commitc631ce211e8c1b2b974914067b432c886976d7f4
treeb7b840975a2c5a5d78376d8ba750896a8bc061a3
parent98e97bfc7633fa1d0e82589878b95cdc5f0c44a9
drm/tegra: Remove gratuitous pad field

The version of the drm_tegra_submit structure that was merged all the
way back in 3.10 contains a pad field that was originally intended to
properly pad the following __u64 field. Unfortunately it seems like a
different field was dropped during review that caused this padding to
become unnecessary, but the pad field wasn't removed at that time.

One possible side-effect of this is that since the __u64 following the
pad is now no longer properly aligned, the compiler may (or may not)
introduce padding itself, which results in no predictable ABI.

Rectify this by removing the pad field so that all fields are again
naturally aligned. Technically this is breaking existing userspace ABI,
but given that there aren't any (released) userspace drivers that make
use of this yet, the fallout should be minimal.

Fixes: 5a414a1988fb ("drm/tegra: Add gr2d device")
Cc: <stable@vger.kernel.org> # 3.10
Signed-off-by: Thierry Reding <treding@nvidia.com>
include/uapi/drm/tegra_drm.h