]> git.baikalelectronics.ru Git - kernel.git/commit
ocfs2: fix subdirectory registration with register_sysctl()
authorLinus Torvalds <torvalds@linux-foundation.org>
Fri, 28 Jan 2022 08:00:29 +0000 (10:00 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 28 Jan 2022 16:15:16 +0000 (18:15 +0200)
commitc5a506164f0a5b351b7ffef7d6c553aec7094fae
tree2b60c3521a82ef4c07b2949b5bb973eb53a6ff59
parent65d5d2de88a25f9cfae243e5f41db82fb03f24eb
ocfs2: fix subdirectory registration with register_sysctl()

The kernel test robot reports that commit 5260a8fc5fc5 ("ocfs2: simplify
subdirectory registration with register_sysctl()") is broken, and
results in kernel warning messages like

  sysctl table check failed: fs/ocfs2/nm Not a file
  sysctl table check failed: fs/ocfs2/nm No proc_handler
  sysctl table check failed: fs/ocfs2/nm bogus .mode 0555

and in fact this was already reported back in linux-next, but nobody
seems to have reacted to that report.  Possibly that original report
only ever made it to the lkp list.

The problem seems to be that the simplification didn't actually go far
enough, and should have converted the whole directory path to the final
sysctl file, rather than just the two first components.

So take that last step.

Fixes: 5260a8fc5fc5 ("ocfs2: simplify subdirectory registration with register_sysctl()")
Reported-by: kernel test robot <oliver.sang@intel.com>
Link: https://lore.kernel.org/all/20220128065310.GF8421@xsang-OptiPlex-9020/
Link: https://lists.01.org/hyperkitty/list/lkp@lists.01.org/thread/KQ2F6TPJWMDVEXJM4WTUC4DU3EH3YJVT/
Tested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ocfs2/stackglue.c