]> git.baikalelectronics.ru Git - kernel.git/commit
vsock: split dwork to avoid reinitializations
authorCong Wang <xiyou.wangcong@gmail.com>
Mon, 6 Aug 2018 18:06:02 +0000 (11:06 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 7 Aug 2018 19:39:13 +0000 (12:39 -0700)
commitc50c4c0148a2f8f9356b9ef813e2ce645a906cfc
treeddd03269c5845932976a7e947b6efc2d168cea80
parent97b4a4060d2fda7ffac9cebc07eacf3d18ca4391
vsock: split dwork to avoid reinitializations

syzbot reported that we reinitialize an active delayed
work in vsock_stream_connect():

ODEBUG: init active (active state 0) object type: timer_list hint:
delayed_work_timer_fn+0x0/0x90 kernel/workqueue.c:1414
WARNING: CPU: 1 PID: 11518 at lib/debugobjects.c:329
debug_print_object+0x16a/0x210 lib/debugobjects.c:326

The pattern is apparently wrong, we should only initialize
the dealyed work once and could repeatly schedule it. So we
have to move out the initializations to allocation side.
And to avoid confusion, we can split the shared dwork
into two, instead of re-using the same one.

Fixes: 031acdb8ab77 ("VSOCK: Introduce VM Sockets")
Reported-by: <syzbot+8a9b1bd330476a4f3db6@syzkaller.appspotmail.com>
Cc: Andy king <acking@vmware.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Jorgen Hansen <jhansen@vmware.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/af_vsock.h
net/vmw_vsock/af_vsock.c
net/vmw_vsock/vmci_transport.c