]> git.baikalelectronics.ru Git - kernel.git/commit
x86, um: actually mark system call tables readonly
authorDaniel Borkmann <dborkman@redhat.com>
Sat, 3 Jan 2015 12:11:10 +0000 (13:11 +0100)
committerRichard Weinberger <richard@nod.at>
Sun, 4 Jan 2015 13:21:25 +0000 (14:21 +0100)
commitc4c25dd62ac2e21f000a02277413f31a614a118b
treeee1d63514ef4765a829b21849b5ae863bfe22a99
parentf1b026501b5a76864d598b053ba9ad41fdd3403c
x86, um: actually mark system call tables readonly

Commit 0dbeadf4af2b ("x86, um: Mark system call tables readonly") was
supposed to mark the sys_call_table in UML as RO by adding the const,
but it doesn't have the desired effect as it's nevertheless being placed
into the data section since __cacheline_aligned enforces sys_call_table
being placed into .data..cacheline_aligned instead. We need to use
the ____cacheline_aligned version instead to fix this issue.

Before:

$ nm -v arch/x86/um/sys_call_table_64.o | grep -1 "sys_call_table"
                 U sys_writev
0000000000000000 D sys_call_table
0000000000000000 D syscall_table_size

After:

$ nm -v arch/x86/um/sys_call_table_64.o | grep -1 "sys_call_table"
                 U sys_writev
0000000000000000 R sys_call_table
0000000000000000 D syscall_table_size

Fixes: 0dbeadf4af2b ("x86, um: Mark system call tables readonly")
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
arch/x86/um/sys_call_table_32.c
arch/x86/um/sys_call_table_64.c