]> git.baikalelectronics.ru Git - kernel.git/commit
radeonfb/aty128fb: Disable broken early resume hook for PowerBooks
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Tue, 10 Mar 2009 23:45:17 +0000 (10:45 +1100)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Tue, 10 Mar 2009 23:48:56 +0000 (10:48 +1100)
commitc4071073ee4f6649bcfab079a874a9b47ca73d33
tree777e46af2366ce8ffa0dd5c1a9fcead8b6ef5fdb
parentd943ac35ff865af70528e04b65cd9b2c861c49af
radeonfb/aty128fb: Disable broken early resume hook for PowerBooks

radeonfb and aty128fb have a special hook called by the PowerMac platform
code very very early on resume from sleep to bring the screen back. This
is useful for debugging wakup problems, but unfortunately, this also became
a source of problems of its own.

The hook is called extremely early, with interrupts still off, and the code
path involved with that code nowadays rely on things like taking mutexes,
GFP_KERNEL allocations, etc...

In addition, the driver now relies on the PCI core to restore the standard
config space before calling resume which doesn't happen with this early
code path.

I'm keeping the code in but commented out along with a fixup call to
pci_restore_state(). The reason is that I still want to make it easy to
re-enable temporarily to track wake up problems, and it's possible that
I can revive it at some stage if we make sleeping things save to call
in early resume using a system state.

In the meantime, this should fix several reported regressions.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
drivers/video/aty/aty128fb.c
drivers/video/aty/radeon_pm.c