]> git.baikalelectronics.ru Git - kernel.git/commit
s390/qeth: fix underestimated count of buffer elements
authorUrsula Braun <ubraun@linux.vnet.ibm.com>
Fri, 9 Feb 2018 10:03:49 +0000 (11:03 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 9 Feb 2018 19:30:23 +0000 (14:30 -0500)
commitc3de69b39ee056ade2827d68cb5d2828e84c770f
tree8914755732ad1d2d5eca6c0be6d64d05806eb23d
parent23995a49fb15847cc653fea32367e3e032e1f132
s390/qeth: fix underestimated count of buffer elements

For a memory range/skb where the last byte falls onto a page boundary
(ie. 'end' is of the form xxx...xxx001), the PFN_UP() part of the
calculation currently doesn't round up to the next PFN due to an
off-by-one error.
Thus qeth believes that the skb occupies one page less than it
actually does, and may select a IO buffer that doesn't have enough spare
buffer elements to fit all of the skb's data.
HW detects this as a malformed buffer descriptor, and raises an
exception which then triggers device recovery.

Fixes: ed0d33e2b894 ("qeth: refactor calculation of SBALE count")
Signed-off-by: Ursula Braun <ubraun@linux.vnet.ibm.com>
Signed-off-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_core.h