]> git.baikalelectronics.ru Git - kernel.git/commit
KVM: Don't create VM debugfs files outside of the VM directory
authorOliver Upton <oupton@google.com>
Wed, 6 Apr 2022 23:56:13 +0000 (23:56 +0000)
committerMarc Zyngier <maz@kernel.org>
Thu, 7 Apr 2022 07:46:13 +0000 (08:46 +0100)
commitc3d82a65b83c53a579d5ad6eeb0527dba5873a14
tree9d17a264e3770296f052f2bb4419ad218632232d
parent384205fd84ca28ba802e3e3250fda7cca2b6a336
KVM: Don't create VM debugfs files outside of the VM directory

Unfortunately, there is no guarantee that KVM was able to instantiate a
debugfs directory for a particular VM. To that end, KVM shouldn't even
attempt to create new debugfs files in this case. If the specified
parent dentry is NULL, debugfs_create_file() will instantiate files at
the root of debugfs.

For arm64, it is possible to create the vgic-state file outside of a
VM directory, the file is not cleaned up when a VM is destroyed.
Nonetheless, the corresponding struct kvm is freed when the VM is
destroyed.

Nip the problem in the bud for all possible errant debugfs file
creations by initializing kvm->debugfs_dentry to -ENOENT. In so doing,
debugfs_create_file() will fail instead of creating the file in the root
directory.

Cc: stable@kernel.org
Fixes: 9224dbb621bc ("kvm: no need to check return value of debugfs_create functions")
Signed-off-by: Oliver Upton <oupton@google.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220406235615.1447180-2-oupton@google.com
virt/kvm/kvm_main.c