]> git.baikalelectronics.ru Git - kernel.git/commit
media: coda: Clear the interrupt reason
authorEzequiel Garcia <ezequiel@collabora.com>
Thu, 2 May 2019 22:00:45 +0000 (18:00 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 28 May 2019 16:23:15 +0000 (12:23 -0400)
commitc2c80fd8900b5acae33e4a4a3d67e0ea4f0448ac
treed3f2336ec137f53810a7c0f038e26b4ac77e6084
parentb16fe0372c2f1b4bc9a87fae7cbd27fcca68b174
media: coda: Clear the interrupt reason

This commit clears the interrupt reason (INT_REASON) register
on the interrupt handler. Without this clearing, the CODA hardware
has been observed to get completely stalled on CODA980 variants,
requiring a pretty deep hardware reset.

The datasheet specifies that the INT_REASON register is set
by the CODA hardware, and should be cleared by the host.

While the CODA versions that are currently supported by this driver
don't seem to need this change, it's a really small change,
so it seems a wise thing to do to avoid hitting some
rare race-condition in the hardware.

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/coda/coda-bit.c