]> git.baikalelectronics.ru Git - kernel.git/commit
iommu/rockchip: Don't provoke WARN for harmless IRQs
authorRobin Murphy <robin.murphy@arm.com>
Mon, 11 Nov 2019 18:55:18 +0000 (18:55 +0000)
committerJoerg Roedel <jroedel@suse.de>
Tue, 12 Nov 2019 16:07:47 +0000 (17:07 +0100)
commitc2c4b5392c61dfc435583ae3117bc237a1c65fe4
treebf2154407d2a42c61defaf8777742ca656907243
parent6b45109de3347f9e9d02f870e615e476bc2bec38
iommu/rockchip: Don't provoke WARN for harmless IRQs

Although we don't generally expect IRQs to fire for a suspended IOMMU,
there are certain situations (particularly with debug options) where
we might legitimately end up with the pm_runtime_get_if_in_use() call
from rk_iommu_irq() returning 0. Since this doesn't represent an actual
error, follow the other parts of the driver and save the WARN_ON()
condition for a genuine negative value. Even if we do have spurious
IRQs due to a wedged VOP asserting the shared line, it's not this
driver's job to try to second-guess the IRQ core to warn about that.

Reported-by: Vasily Khoruzhick <anarsoul@gmail.com>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Acked-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/rockchip-iommu.c