]> git.baikalelectronics.ru Git - kernel.git/commit
bnxt_en: Fix aggregation buffer leak under OOM condition.
authorMichael Chan <michael.chan@broadcom.com>
Wed, 22 May 2019 23:12:54 +0000 (19:12 -0400)
committerDavid S. Miller <davem@davemloft.net>
Thu, 23 May 2019 01:02:14 +0000 (18:02 -0700)
commitc20f6758b232979bd3b0a38148e224869db6d3b4
tree9a0e5b263c6339371405b36b14af2fcce63e2734
parent181a59177902c4a68dbb7e810cfed897cc02c53c
bnxt_en: Fix aggregation buffer leak under OOM condition.

For every RX packet, the driver replenishes all buffers used for that
packet and puts them back into the RX ring and RX aggregation ring.
In one code path where the RX packet has one RX buffer and one or more
aggregation buffers, we missed recycling the aggregation buffer(s) if
we are unable to allocate a new SKB buffer.  This leads to the
aggregation ring slowly running out of buffers over time.  Fix it
by properly recycling the aggregation buffers.

Fixes: 93658deae41f ("bnxt_en: New Broadcom ethernet driver.")
Reported-by: Rakesh Hemnani <rhemnani@fb.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt.c