]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Fix coredump of perma-pinned vmas
authorThomas Hellström <thomas.hellstrom@linux.intel.com>
Wed, 8 Dec 2021 08:22:45 +0000 (09:22 +0100)
committerThomas Hellström <thomas.hellstrom@linux.intel.com>
Mon, 13 Dec 2021 11:14:01 +0000 (12:14 +0100)
commitc1de687790a9eec13c51bb1641e29e01e8abddb3
tree553744834468220f7897a5fcb1a6c9f53f82ba98
parente6780e9685523e755a84873e4060f8ca216ecaa7
drm/i915: Fix coredump of perma-pinned vmas

When updating the error capture code and introducing vma snapshots,
we introduced code to hold the vma in memory while capturing it,
calling i915_active_acquire_if_busy(). Now that function isn't relevant
for perma-pinned vmas and caused important vmas to be dropped from the
coredump. Like for example the GuC log.

Fix this by instead requiring those vmas to be pinned while capturing.

Tested by running the initial subtests of the gem_exec_capture igt test
with GuC submission enabled and verifying that a GuC log blob appears
in the output.

Fixes: c310ed796a81 ("drm/i915: Update error capture code to avoid using the current vma state")
Cc: Ramalingam C <ramalingam.c@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reported-by: John Harrison <John.C.Harrison@Intel.com>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211208082245.86933-1-thomas.hellstrom@linux.intel.com
drivers/gpu/drm/i915/i915_gpu_error.c