]> git.baikalelectronics.ru Git - kernel.git/commit
x86/mm/32: Load a sane CR3 before cpu_init() on secondary CPUs
authorAndy Lutomirski <luto@kernel.org>
Sun, 17 Sep 2017 16:03:51 +0000 (09:03 -0700)
committerIngo Molnar <mingo@kernel.org>
Sun, 17 Sep 2017 16:59:09 +0000 (18:59 +0200)
commitc18cd4240ca60826b1962afe3b4c83dce52da102
tree1f2760ddbd6d5e8b97f824206b506ee9a892e2c4
parentb9173faeac8b029cfe5da2fcba6bd477417ad7d0
x86/mm/32: Load a sane CR3 before cpu_init() on secondary CPUs

For unknown historical reasons (i.e. Borislav doesn't recall),
32-bit kernels invoke cpu_init() on secondary CPUs with
initial_page_table loaded into CR3.  Then they set
current->active_mm to &init_mm and call enter_lazy_tlb() before
fixing CR3.  This means that the x86 TLB code gets invoked while CR3
is inconsistent, and, with the improved PCID sanity checks I added,
we warn.

Fix it by loading swapper_pg_dir (i.e. init_mm.pgd) earlier.

Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
Reported-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Borislav Petkov <bpetkov@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 61b4fe59f7f4 ("x86/mm: Reinitialize TLB state on hotplug and resume")
Link: http://lkml.kernel.org/r/30cdfea504682ba3b9012e77717800a91c22097f.1505663533.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/smpboot.c