]> git.baikalelectronics.ru Git - kernel.git/commit
rhashtable: Do not schedule more than one rehash if we can't grow further
authorThomas Graf <tgraf@suug.ch>
Wed, 22 Apr 2015 07:41:46 +0000 (09:41 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 22 Apr 2015 18:17:22 +0000 (14:17 -0400)
commitc179b685b1089925a2e0323288e1d85a84dfb1c1
treea28503490179133baff9275d428a3c0c31f35e4e
parent8dbbc15c0b21b06ef989e684f612b40c3539f742
rhashtable: Do not schedule more than one rehash if we can't grow further

The current code currently only stops inserting rehashes into the
chain when no resizes are currently scheduled. As long as resizes
are scheduled and while inserting above the utilization watermark,
more and more rehashes will be scheduled.

This lead to a perfect DoS storm with thousands of rehashes
scheduled which lead to thousands of spinlocks to be taken
sequentially.

Instead, only allow either a series of resizes or a single rehash.
Drop any further rehashes and return -EBUSY.

Fixes: 43719bf4351e ("rhashtable: Add immediate rehash during insertion")
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
lib/rhashtable.c