]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: hda: Fix regression by strip mask fix
authorTakashi Iwai <tiwai@suse.de>
Sat, 14 Dec 2019 17:52:17 +0000 (18:52 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sat, 14 Dec 2019 17:54:47 +0000 (18:54 +0100)
commitc0283bcd345040d23c8fcedd294cb1d13ef4e774
treecfe4be366d127ad83c8f21c8c83b4ef7ceca66c9
parent2913464d37342b629ce60666127e2af9d7e49bb8
ALSA: hda: Fix regression by strip mask fix

The commit ff4e8de6e1ff ("ALSA: hda: Modify stream stripe mask only
when needed") tried to address the regression by the unconditional
application of the stripe mask, but this caused yet another
regression for the previously working devices.  Namely, the patch
clears the azx_dev->stripe flag at snd_hdac_stream_clear(), but this
may be called multiple times before restarting the stream, so this
ended up with clearance of the flag for the whole time.

This patch fixes the regression by moving the azx_dev->stripe flag
clearance at the counter-part, the close callback of HDMI codec
driver instead.

Fixes: ff4e8de6e1ff ("ALSA: hda: Modify stream stripe mask only when needed")
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205855
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=204477
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20191214175217.31852-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/hda/hdac_stream.c
sound/pci/hda/patch_hdmi.c