]> git.baikalelectronics.ru Git - kernel.git/commit
s390/uv: fully validate the VMA before calling follow_page()
authorDavid Hildenbrand <david@redhat.com>
Thu, 9 Sep 2021 16:22:44 +0000 (18:22 +0200)
committerChristian Borntraeger <borntraeger@de.ibm.com>
Mon, 25 Oct 2021 07:20:38 +0000 (09:20 +0200)
commitbff75ff4f92d748d4f74137f2c002204ab1ec8c5
tree17bec98f76067e1b445d34ce8be01df78fe2f575
parent07792efedac26f394b01e7c2c8e753c2411a8316
s390/uv: fully validate the VMA before calling follow_page()

We should not walk/touch page tables outside of VMA boundaries when
holding only the mmap sem in read mode. Evil user space can modify the
VMA layout just before this function runs and e.g., trigger races with
page table removal code since commit 5dcd5782f466 ("mm: mmap: zap pages
with read mmap_sem in munmap").

find_vma() does not check if the address is >= the VMA start address;
use vma_lookup() instead.

Fixes: a92898e4d7ed ("s390/mm: provide memory management functions for protected KVM guests")
Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Acked-by: Heiko Carstens <hca@linux.ibm.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
Link: https://lore.kernel.org/r/20210909162248.14969-6-david@redhat.com
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
arch/s390/kernel/uv.c