]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: don't disable_fbc() if FBC is already disabled
authorPaulo Zanoni <paulo.r.zanoni@intel.com>
Wed, 4 Nov 2015 19:10:51 +0000 (17:10 -0200)
committerMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Tue, 10 Nov 2015 09:59:45 +0000 (10:59 +0100)
commitbf43f2992db6b00bf2279a2acebb6e7cbdd5ee98
tree591c9224a7def08e69c1d3346dba4bf52ae53da3
parenta3651aad806758bcba3637481f088f33b0e0e9ca
drm/i915: don't disable_fbc() if FBC is already disabled

If FBC is disabled we will still call intel_fbc_invalidate(), and as a
result we may call intel_fbc_deactivate(), which will try to touch
registers.

I'm pretty sure I saw this happen on a runtime suspended device, and
I'm almost sure I was running igt/pm_rpm. It produced the "you touched
registers while the device is suspended" WARNs. But this was some time
ago and I can't remember exactly which conditions were necessary to
reproduce the problem.

v2: Rebase to new series order.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1446664257-32012-8-git-send-email-paulo.r.zanoni@intel.com
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
drivers/gpu/drm/i915/intel_fbc.c