]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "rt2x00: Endless loop on hub port power down"
authorStanislaw Gruszka <sgruszka@redhat.com>
Wed, 26 Nov 2014 14:29:16 +0000 (15:29 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 1 Dec 2014 20:57:21 +0000 (15:57 -0500)
commitbf391fc0c7b9ae89d31e7da5af929f8c6f69eb8c
tree8267ca6c9b118984c4a76546a81f6e43d085add1
parentd01f28517b9e5eec66fcca22c0abca074af6adf7
Revert "rt2x00: Endless loop on hub port power down"

This reverts commit 6a96f33720c6e8ce81296099893646a8bdb0d06e. It
causes wireless device disappear when we get -EPROTO error form USB
request. I encounter such situation occasionally when resume form
suspend with RT3070 adapter:

[  289.619985] ieee80211 phy0: rt2x00usb_vendor_request: Error - Vendor Request 0x06 failed for offset 0x0404 with error -71
[  289.639368] ieee80211 phy0: rt2800_wait_bbp_ready: Error - BBP register access failed, aborting
[  289.639374] ieee80211 phy0: rt2800usb_set_device_state: Error - Device failed to enter state 4 (-5)

Without the patch, except printing error, device works just fine after
resume.

Currently after timeouts and REGISTER_BUSY_COUNT tuning, we should
not have any "endless loop", though we can wait quite long when driver
is trying to communicate with the device through non functioning USB
connection. Generally the problem that commit 6a96f33720c6e solves
is kinda artificial.

Cc: Richard Genoud <richard.genoud@gmail.com>
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rt2x00/rt2x00usb.c