]> git.baikalelectronics.ru Git - kernel.git/commit
MIPS: Correct forced syscall errors
authorJames Hogan <james.hogan@imgtec.com>
Thu, 29 Jun 2017 09:12:35 +0000 (10:12 +0100)
committerRalf Baechle <ralf@linux-mips.org>
Tue, 11 Jul 2017 12:13:06 +0000 (14:13 +0200)
commitbecddba9f80f26a2b9ebe9bad2806304ed5e00e1
tree93e393bee3f3bf46d62e208da2ced0b7022c8605
parent4f32a39d49b25eaa66d2420f1f03d371ea4cd906
MIPS: Correct forced syscall errors

When the system call return value is forced to be an error (for example
due to SECCOMP_RET_ERRNO), syscall_set_return_value() puts the error
code in the return register $v0 and -1 in the error register $a3.

However normally executed system calls put 1 in the error register
rather than -1, so fix syscall_set_return_value() to be consistent with
that.

I don't anticipate that anything would have been broken by this, since
the most natural way to check the error register on MIPS would be a
conditional branch if error register is [not] equal to zero (bnez or
beqz).

Fixes: 1d7bf993e073 ("MIPS: ftrace: Add support for syscall tracepoints.")
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/16652/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/include/asm/syscall.h