]> git.baikalelectronics.ru Git - kernel.git/commit
net: enetc: fix the incorrect clearing of IF_MODE bits
authorVladimir Oltean <vladimir.oltean@nxp.com>
Thu, 23 Sep 2021 13:23:33 +0000 (16:23 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 24 Sep 2021 13:03:04 +0000 (14:03 +0100)
commitbe10b9aabd1c6bfc7fba08822fda68fefd78a72f
tree6155c696c4b6759e697a7b1a907ce99525499d8f
parent7f04a98adcb14548a2eb5b052b53b2c18da4f508
net: enetc: fix the incorrect clearing of IF_MODE bits

The enetc phylink .mac_config handler intends to clear the IFMODE field
(bits 1:0) of the PM0_IF_MODE register, but incorrectly clears all the
other fields instead.

For normal operation, the bug was inconsequential, due to the fact that
we write the PM0_IF_MODE register in two stages, first in
phylink .mac_config (which incorrectly cleared out a bunch of stuff),
then we update the speed and duplex to the correct values in
phylink .mac_link_up.

Judging by the code (not tested), it looks like maybe loopback mode was
broken, since this is one of the settings in PM0_IF_MODE which is
incorrectly cleared.

Fixes: 1c91142f1fa3 ("net: enetc: force the RGMII speed and duplex instead of operating in inband mode")
Reported-by: Pavel Machek (CIP) <pavel@denx.de>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/enetc/enetc_pf.c