]> git.baikalelectronics.ru Git - kernel.git/commit
drm/omap: fix possible object reference leak
authorWen Yang <wen.yang99@zte.com.cn>
Mon, 8 Apr 2019 02:58:32 +0000 (10:58 +0800)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 11 Feb 2020 09:46:51 +0000 (11:46 +0200)
commitbd554f36e55e28d463777e076afbac8d7eabbb93
tree4bf8e9157499f4294ac3657eba2733ef2896b6bc
parent25ec6e211fce4224d75c087cb4c0ee324c22c75e
drm/omap: fix possible object reference leak

The call to of_find_matching_node returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c:212:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 209, but without a corresponding object release within this function.
drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c:237:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 209, but without a corresponding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
Cc: Markus Elfring <Markus.Elfring@web.de>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1554692313-28882-2-git-send-email-wen.yang99@zte.com.cn
drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c