]> git.baikalelectronics.ru Git - kernel.git/commit
perf tools: Fix misleading add event PMU debug message
authorAdrian Hunter <adrian.hunter@intel.com>
Mon, 11 Apr 2022 06:17:58 +0000 (09:17 +0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 13 Apr 2022 10:00:31 +0000 (07:00 -0300)
commitbd1f18c8f9251fd7c3d60a0418a585a26178165f
treed13274a272f3706a2a670948070f950ef9dd72a0
parentf2238f2702f6e6b930129e05903f059ec603759a
perf tools: Fix misleading add event PMU debug message

Fix incorrect debug message:

   Attempting to add event pmu 'intel_pt' with '' that may result in
   non-fatal errors

which always appears with perf record -vv and intel_pt e.g.

    perf record -vv -e intel_pt//u uname

The message is incorrect because there will never be non-fatal errors.

Suppress the message if the PMU is 'selectable' i.e. meant to be
selected directly as an event.

Fixes: 7daf45a279036f2e ("perf parse-events: Make add PMU verbose output clearer")
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: http://lore.kernel.org/lkml/20220411061758.2458417-1-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/parse-events.c