]> git.baikalelectronics.ru Git - kernel.git/commit
[media] m5mols: introduce missing initialization
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 18 Aug 2012 20:25:59 +0000 (17:25 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 14 Sep 2012 14:08:40 +0000 (11:08 -0300)
commitbd19a2f3d6e5420270664047d6f5846118678172
tree2efa59ed594532e51ef9427f822e00b2a15df10a
parent16754040c53f0cf2db68cce89f4f9a06de1ca3d1
[media] m5mols: introduce missing initialization

The result of one call to a function is tested, and then at the second call
to the same function, the previous result, and not the current result, is
tested again.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression ret;
identifier f;
statement S1,S2;
@@

*ret = f(...);
if (\(ret != 0\|ret < 0\|ret == NULL\)) S1
... when any
*f(...);
if (\(ret != 0\|ret < 0\|ret == NULL\)) S2
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/i2c/m5mols/m5mols_core.c